Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod directories with non-ASCII names aren't displayed correctly #895

Open
lethal-guitar opened this issue Nov 20, 2022 · 4 comments
Open
Labels

Comments

@lethal-guitar
Copy link
Owner

No description provided.

@naftalimurgor
Copy link
Contributor

naftalimurgor commented Dec 9, 2023

Hello @lethal-guitar 👋

How are you doing. Would like to give this a shot. How do we reproduce this this and also never thought of non-ASCII names for files and directories until seeing this.

@lethal-guitar
Copy link
Owner Author

Hi @naftalimurgor, doing alright, thanks! Happy to hear you're interested in tackling this 🙂

To reproduce:

  • Download one of the mods from the list
  • Place it into <Game data dir>/mods/<name of mod>
  • Rename the directory to contain some non-ASCII characters, e.g. Täßtîng 東京
  • Now, when you launch the game and open the mod manager in the options menu, the non-ASCII characters will be displayed as ???? in the UI.

This happens due to the built-in font coming with the Dear ImGui library not having Unicode glyphs. There should be a fair bit of information on how to add Unicode support on the Dear ImGui wiki.

@naftalimurgor
Copy link
Contributor

Hey @lethal-guitar
Glad to hear you are doing well!
Taking on this. and will submit a PR as soon as things are set up!

@naftalimurgor
Copy link
Contributor

Hello @lethal-guitar 👋

I hope you are doing great, been quite busy with college and school work.

Regarding this issue, I found out an issue describing similar edge case faced here: ocornut/imgui#565
Hopefully the pointers highlighted in this issue will help resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants