Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial update of the typing #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

julienmarantes
Copy link

@julienmarantes julienmarantes commented Sep 6, 2019

I added class attributes that were missing from the typing from the last version of mxgraph (cf: diff)

Changed some params that should be optionnal, to be optionnal.

Correced some params typing that should not be alowwed to be null.

Some indentation corrections.

@julienmarantes
Copy link
Author

Just saw one of the last pull request on the null params : If null is specified as the id, then the id is automatically created.

I don't know if it's the normal behavior, but from my point of view passing null to a function for a specific behavior wouldn't be a good practice..

@lgleim
Copy link
Owner

lgleim commented Sep 6, 2019

I don't know if it's the normal behavior, but from my point of view passing null to a function for a specific behavior wouldn't be a good practice..

Please note that this repository only contains typings, not code. So any complaints about the code style should go to the upstream repository.

Also: Your pull request contains actual code, not typings. As such, I kindly ask you to review your pull request and remove the included implementation code to avoid conflicts.

undo indentation changes

correct wrong types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants