Consolidate All Parsing Methods #260
Comments
pbauman
added a commit
to pbauman/antioch
that referenced
this issue
Jul 10, 2018
This one takes a pointer to a ParserBase object and then does the read. Slight refactoring of existing function to reuse existing capability. Really, this should just all be in the ParserBase and XMLParser classes, but until we address libantioch#260, we're stuck with this simple change/(gross) API extension.
pbauman
added a commit
to pbauman/antioch
that referenced
this issue
Jul 10, 2018
This one takes a pointer to a ParserBase object and then does the read. Slight refactoring of existing function to reuse existing capability. Really, this should just all be in the ParserBase and XMLParser classes, but until we address libantioch#260, we're stuck with this simple change/(gross) API extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's scattered global functions for parsing things, but these should just be base class methods in the ParserBase object and then using virtual functions for implementation specific things. Right now, this is 1. Confusing as hell to figure out what's going on, 2. Makes it harder to update to use new features, e.g. #254 where we can now specify the gas mixture to select what we want if there's multiple sections in the XML file; right now we can't use it for kinetics., 3. Messy.
#250 will be a step in this direction. This will also help with #249.
The text was updated successfully, but these errors were encountered: