Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-dialer max queue should allow specifying max queue per transport #1897

Closed
SgtPooki opened this issue Jul 25, 2023 · 3 comments
Closed

Comments

@SgtPooki
Copy link
Member

https://github.com/libp2p/js-libp2p/blob/7debe0312f6df68e27dc26410a745c98477abe59/packages/libp2p/src/connection-manager/auto-dial.ts#L122C32-L122C54

WebTransport currently only supports 64 instances: #1896

Others may have their own limits (or none) and users should be able to limit autoDialMaxQueueLength by transport.

@SgtPooki
Copy link
Member Author

related to #744 (comment)

@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Jul 26, 2023
@maschad maschad self-assigned this Jul 26, 2023
@maschad maschad removed their assignment Aug 29, 2023
@maschad
Copy link
Member

maschad commented Aug 29, 2023

Others may have their own limits (or none) and users should be able to limit autoDialMaxQueueLength by transport.

Given that it turns out this is actually an issue in chrome as discussed here this may not be the best solution since the dials are actually not pending (and thus shouldn't be in the dial queue at that point)

That being said this may be a good thing to have in the future.

@maschad maschad moved this from 🥞Weekly Candidates/Discuss🎙 to 🛠️ Todo in js-libp2p Aug 29, 2023
@achingbrain
Copy link
Member

Closing as the problem this proposal attempts to solve actually seems to be a bug in Chrome around WebTransport sessions never leaving the pending state.

This feature may be worth investigating in the future if a requirement surfaces but right now it's not something we need.

@github-project-automation github-project-automation bot moved this from 🛠️ Todo to 🎉Done in js-libp2p Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants