bug: connection manager seems to have no awareness of pending connections

[SgtPooki]

js-libp2p/packages/libp2p/src/connection-manager/index.ts

Lines 486 to 533 in 7debe03

	async openConnection (peerIdOrMultiaddr: PeerId | Multiaddr | Multiaddr[], options: OpenConnectionOptions = {}): Promise<Connection> {
	if (!this.isStarted()) {
	throw new CodeError('Not started', codes.ERR_NODE_NOT_STARTED)
	}
	options.signal?.throwIfAborted()
	const { peerId } = getPeerAddress(peerIdOrMultiaddr)
	if (peerId != null) {
	log('dial %p', peerId)
	const existingConnections = this.getConnections(peerId)
	if (existingConnections.length > 0) {
	log('had an existing connection to %p', peerId)
	return existingConnections[0]
	}
	}
	const connection = await this.dialQueue.dial(peerIdOrMultiaddr, {
	...options,
	priority: options.priority ?? DEFAULT_DIAL_PRIORITY
	})
	let peerConnections = this.connections.get(connection.remotePeer)
	if (peerConnections == null) {
	peerConnections = []
	this.connections.set(connection.remotePeer, peerConnections)
	}
	// we get notified of connections via the Upgrader emitting "connection"
	// events, double check we aren't already tracking this connection before
	// storing it
	let trackedConnection = false
	for (const conn of peerConnections) {
	if (conn.id === connection.id) {
	trackedConnection = true
	}
	}
	if (!trackedConnection) {
	peerConnections.push(connection)
	}
	return connection
	}

WebTransport dial attempts take a while, and doing some testing with https://github.com/SgtPooki/helia-playground/blob/152e52846c6b3a83d0c13690030a99e3e80c3f70/src/webtransport.ts#L324-L327C9 showed that auto-dialer kept trying to dial the same address, even though the webTransport connection to the exact same URL was already attempted and is currently pending.

connection-manager should be aware of all pending outgoing dial attempts, and not be re-attempting multiaddrs that have pending dials already in flight.

related to #744 (comment)

[SgtPooki]

maybe

js-libp2p/packages/libp2p/src/connection-manager/auto-dial.ts

Lines 167 to 170 in 7debe03

	if (this.queue.hasJob(peer.id)) {
	log.trace('not autodialing %p because they are already being autodialed')
	return false
	}

isn't doing what it's supposed to?

[maschad]

Closed by #1943