Valid move snapping for draw arrow not working correctly

[KartikWatts]

Description:

During my recent game analysis, I encountered a minor issue with the valid move-snapping functionality for the draw arrow.

Problem:

Even when defaultSnapToValidMove is true, if the right mouse button is pressed and the pointer moves outside of the chessboard before being released, the snapping feature fails to work as expected. This occurs because the cur.snapToValidMove value is not being updated properly.

Steps to Reproduce:

1. Press and hold the right mouse button to draw an arrow.
2. Move the pointer outside of the chessboard.
3. Bring the pointer back onto the chessboard.

Attaching GIF for reference:

Expected Behavior:

The draw arrow should snap to the valid move after the pointer returns to the chessboard.

Actual Behavior:

The draw arrow does not snap to the valid move because cur.snapToValidMove is not updated.

[KartikWatts]

Considering it as a bug, a small fix was required, raised a PR to close this: #308. Regards.

[fitztrev]

Hi, this is actually intended

lichess-org/lila#11713
lichess-org/lila#9095
lichess-org/lila#8313
lichess-org/lila#15073

[KartikWatts]

Oops got it 🙈. Thanks.