Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DepositSecurityModule contract instead of EOA in scenario tests #359

Open
Psirex opened this issue Oct 11, 2021 · 1 comment
Open

Use DepositSecurityModule contract instead of EOA in scenario tests #359

Psirex opened this issue Oct 11, 2021 · 1 comment
Labels
next-upgrade Things to pickup for the next protocol upgrade

Comments

@Psirex
Copy link
Contributor

Psirex commented Oct 11, 2021

At this moment deployDaoAndPool accepts EOA depositor address to grant DEPOSIT_ROLE to it. The better way is to deploy and setup DepositSecurityModule in the deployDaoAndPool method and update scenario tests that use depositBufferedEther to make deposits through deployed DepositSecurityModule.
@Psirex Psirex mentioned this issue Oct 14, 2021
Merged
@ujenjt ujenjt added the next-upgrade Things to pickup for the next protocol upgrade label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-upgrade Things to pickup for the next protocol upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ujenjt @Psirex and others