Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 Bridge does not work with SCWs #49

Closed
derekchiang opened this issue Aug 3, 2023 · 4 comments
Closed

L1 Bridge does not work with SCWs #49

derekchiang opened this issue Aug 3, 2023 · 4 comments

Comments

@derekchiang
Copy link

The L1 ERC20 token bridge reverts if the sender is an SCW:

if (Address.isContract(msg.sender)) {
revert ErrorSenderNotEOA();
}

@zdenham
Copy link

zdenham commented Aug 3, 2023

This is an issue as AA wallets are increasingly adopted

@TheDZhon
Copy link
Contributor

TheDZhon commented Aug 9, 2023

Worth noting: https://community.optimism.io/docs/developers/bridge/standard-bridge/#deposits
tl;dr: there is a known limitation even for standard optimism bridge for SCW

@TheDZhon
Copy link
Contributor

TheDZhon commented Aug 9, 2023

UPDATE

You can use depositTo if you know what are you doing for sure

image

If you use the same sender and destination addresses (like deposit does), you might send funds to the wrong address in general (suppose your SCW isn't represented with the same address on L1 and L2).

@TheDZhon
Copy link
Contributor

Closing the issue as being relevant to the design decisions of Opti stack towards having a dedicated depositTo method for SCW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants