Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClayDropdown is not being aligned in the best way #452

Closed
matuzalemsteles opened this issue Jan 24, 2018 · 3 comments
Closed

ClayDropdown is not being aligned in the best way #452

matuzalemsteles opened this issue Jan 24, 2018 · 3 comments
Labels
status: next-release Issues that will enter into the next release

Comments

@matuzalemsteles
Copy link
Member

ClayDropdown is not being aligned correctly, just aligning in a single position in all use cases by ignoring the boundaries of the screen.

screen shot 2018-01-24 at 18 09 50
@carloslancha
Copy link
Contributor

@matuzalemsteles could you try take care of this? Thx!

@matuzalemsteles
Copy link
Member Author

hey @carloslancha, This problem happens because the .dropdown-menu is not visible on the screen for metal-position to get clientHeight and clientWidth.

With the implementation of Portals the syncExpanded is called before the show class is added so that we can see clientWidth...

We can solve this with css by changing display: none to visibility: hidden, but I do not know if it is viable to use it. Another way would be to give the Align.align API a width and height to start, I don't know if it would be ideal.

@Robert-Frampton Do you have any thoughts on this?

matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Jan 26, 2018
@matuzalemsteles
Regen snapshosts | Fixes liferay#452
32f1814
@matuzalemsteles matuzalemsteles mentioned this issue Jan 26, 2018
Merged
jbalsas added a commit that referenced this issue Jan 26, 2018
@jbalsas
Merge pull request #482 from matuzalemsteles/FixDropdownAlign
c0c223a 
Fix the align of the dropdown when expanded in ClayDropdown | Fixes #452
@matuzalemsteles
Copy link
Member Author

Fixed in #482.

@matuzalemsteles matuzalemsteles added the status: next-release Issues that will enter into the next release label Jan 31, 2018
@jbalsas jbalsas closed this as completed in ba47cf4 Feb 1, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Fix the align of the dropdown when expanded in ClayDropdown | Fixes l…
21683b1 
…iferay#452
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Regen snapshosts | Fixes liferay#452
f5245ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carloslancha @matuzalemsteles