Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bLIP-10: ts property needs to specify time units #12

Open
coldacid opened this issue Jan 29, 2022 · 3 comments
Open

bLIP-10: ts property needs to specify time units #12

coldacid opened this issue Jan 29, 2022 · 3 comments

Comments

@coldacid
Copy link

While we may all know right now that ts is supposed to be in seconds, there's nothing actually specifying that in the document. Someone could look at it and think that perhaps it's milliseconds. Or perhaps something odd, like the number of frame headers passed in the mp3 file. Long story short, the time unit should be specified explicitly in the doc.

satoshisstream added a commit to satoshisstream/blips that referenced this issue Jan 31, 2022
@JssDWt
Copy link

JssDWt commented Sep 9, 2022

This is fixed in #13, so can be closed?

@satoshisstream
Copy link
Contributor

yes

@SiddheshKukade
Copy link

SiddheshKukade commented Apr 12, 2023

Hello @satoshisstream , what does the ts field stands for here
does it mean time in seconds OR timestamp? Please explain.
image
Source: https://github.com/lightning/blips/blob/master/blip-0010.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants