Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Pip install failures on windows. #118

Closed
scott-huberty opened this issue May 8, 2023 · 5 comments
Closed

BUG: Pip install failures on windows. #118

scott-huberty opened this issue May 8, 2023 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@scott-huberty
Copy link
Member

Our pip install method fails On windows.
has to do with this line in setup.py:

long_description = (this_directory / "README.md").read_text()

Maybe we can include a fix in #117

@scott-huberty scott-huberty added the bug Something isn't working label May 8, 2023
@christian-oreilly
Copy link
Collaborator

A full error message would be useful. Without it I cannot comment.

@Andesha
Copy link
Contributor

Andesha commented May 29, 2023

just to be clear - it's like due to the path formatting with the wrong slashes...

@scott-huberty
Copy link
Member Author

It was an encoding error in read_text(). Maybe it can be fixed by explicitly specifying what encoding to use but honestly I have not tried to fix it yet!

@scott-huberty scott-huberty added this to the 0.02 milestone Jul 26, 2024
@christian-oreilly
Copy link
Collaborator

@scott-huberty The CI passes with Windows. Should I conclude that this issue was resolved in some PR or is it that this specific issue was not covered by the CI?

@scott-huberty
Copy link
Member Author

Ah yes.. This was closed by #169 !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants