Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#180 fixed duplicate addressbooks showing up when an adressbook is publicly shared and delegated to a user #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#180 fixed duplicate addressbooks showing up when an adressbook is publicly shared and delegated to a user #181

wants to merge 1 commit into from
+122 −58

Conversation

rezk2ll
Copy link
Member

@rezk2ll rezk2ll commented Dec 10, 2021 •
edited
Loading

removeDuplicateSharedAndDelegatedAddressbooks.mp4

@rezk2ll rezk2ll linked an issue Dec 10, 2021 that may be closed by this pull request
When an AB is shared to the user and publicly shared it appears twice #180
Open
alagane
alagane reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@alagane alagane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the case when someone gives you write permission on a public readonly addressbook? You should get the more permissive permission, does it work here?

src/linagora.esn.contact/app/sidebar/sidebar.controller.js Outdated Show resolved Hide resolved
@rezk2ll
Copy link
Member Author

rezk2ll commented Dec 13, 2021

What about the case when someone gives you write permission on a public readonly addressbook? You should get the more permissive permission, does it work here?

done out of the box

@rezk2ll rezk2ll requested a review from alagane December 13, 2021 15:13
alagane
alagane previously approved these changes Dec 13, 2021
View reviewed changes
asmaNode
asmaNode previously approved these changes Dec 14, 2021
View reviewed changes
@renaudboyer
Copy link
Contributor

When looking at the sharee display, only public rights are displayed, there should be the public and the shared delegation rights displayed.
Moreover, it can also means that the edit shared rights will not work.
The merge should combine both rights.

renaudboyer
renaudboyer previously requested changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@renaudboyer renaudboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Displayed address book should display both shared and public rights which is not the case on video demo.

@rezk2ll rezk2ll dismissed stale reviews from asmaNode and alagane via 4a5519a December 21, 2021 15:35
@rezk2ll
Copy link
Member Author

rezk2ll commented Dec 21, 2021

updated demo:

removeDuplicateSharedAndDelegatedAddressbooks.mp4

alagane
alagane previously approved these changes Jan 3, 2022
View reviewed changes
@rezk2ll
issue linagora#180 fixed duplicate addressbooks showing up when an ad…
6dfb155 
…ressbook is publicly shared and delegated to a user
@rezk2ll rezk2ll requested a review from alagane January 4, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alagane alagane alagane approved these changes

@fabienmoyon fabienmoyon Awaiting requested review from fabienmoyon

@oubchid oubchid Awaiting requested review from oubchid

@renaudboyer renaudboyer Awaiting requested review from renaudboyer

@asmaNode asmaNode Awaiting requested review from asmaNode

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When an AB is shared to the user and publicly shared it appears twice
4 participants
@rezk2ll @renaudboyer @alagane @asmaNode