Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce fails with duplicate column names #35

Closed
3 tasks
dougbrn opened this issue Apr 23, 2024 · 2 comments · Fixed by #97
Closed
3 tasks

reduce fails with duplicate column names #35

dougbrn opened this issue Apr 23, 2024 · 2 comments · Fixed by #97
Assignees
Labels
bug Something isn't working

Comments

@dougbrn
Copy link
Collaborator

dougbrn commented Apr 23, 2024

Bug report
reduce cannot handle duplicate column names in multiple nested dataframes, as it "flattens" all the input columns to a single dataframe. Fixing this should wait until #33 is resolved. Knowingly introduced by #34 .

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.
@dougbrn dougbrn added the bug Something isn't working label Apr 23, 2024
@dougbrn dougbrn added this to the v0.1 Release milestone Apr 26, 2024
@wilsonbb
Copy link
Contributor

wilsonbb commented May 2, 2024

One potential solution here is to rename the columns when generating the merged frame to the form layer.column. Then before returning the result frame we rename all of the columns to drop the layer. prefix.

Renaming columns should in theory be cheap here

@wilsonbb wilsonbb self-assigned this May 2, 2024
@dougbrn
Copy link
Collaborator Author

dougbrn commented May 13, 2024

I don't think this is mission-critical for v0.1 so I'm opting to remove it from the milestone for now

@dougbrn dougbrn removed this from the v0.1 Release milestone May 13, 2024
@hombit hombit linked a pull request May 30, 2024 that will close this issue
@hombit hombit closed this as completed in #97 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants