Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP 200 is UNKNOWN in actuator metrics #5882

Open
bytestreme opened this issue Aug 23, 2024 · 3 comments
Open

HTTP 200 is UNKNOWN in actuator metrics #5882

bytestreme opened this issue Aug 23, 2024 · 3 comments

Comments

@bytestreme
Copy link

Spring Boot 3.3.3
Armeria 1.29.0

Looks like there is an issue with setting http status code because when org.springframework.http.server.reactive.observation.DefaultServerRequestObservationConvention calls context.getResponse().getStatusCode(), ArmeriaServerHttpResponse returns null

@bytestreme
Copy link
Author

bytestreme commented Aug 23, 2024

Using also com.linecorp.armeria:armeria-spring-boot3-webflux-starter:1.29.0

@jrhee17
Copy link
Contributor

jrhee17 commented Aug 23, 2024

Hi, there's actually a ObservationConvention defined for Armeria DefaultServiceObservationConvention which can be enabled via ObservationService.

Having said this, let me look into why Spring's integration doesn't work for Armeria in the next working days

@jrhee17
Copy link
Contributor

jrhee17 commented Aug 26, 2024

I found a bug in armeria's implementation which doesn't return the correct status code - I'll try to get this merged in the next milestone 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants