Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the title of the documentation service #5900

Open
ikhoon opened this issue Sep 10, 2024 · 3 comments
Open

Allow customizing the title of the documentation service #5900

ikhoon opened this issue Sep 10, 2024 · 3 comments

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Sep 10, 2024

The title of the documentation service is hard-coded to Armeria documentation service <version>

Armeria documentation service
{versions
? ` ${extractSimpleArtifactVersion(
versions.getArmeriaArtifactVersion(),

Some users may want to override the title to easily distinguish a server from a different phase or role.

DocService
  .builder()
  .webAppTitle("Messaging (Alpha)")
  ...
  .build()

The specified web app title could be appended to the default title.

Armeria documentation service 1.30.1 - Messaging (Alpha)
@dipeshsingh253
Copy link

Hi @ikhoon , I would like to contribute to this issue. Can you please assign it to me??

@ikhoon
Copy link
Contributor Author

ikhoon commented Oct 10, 2024

I've assigned #5219 to you. Do you want to resolve both of them at once?

@dipeshsingh253
Copy link

Yeah, I can do that. This seems a good first issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants