Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move frame interval from the Composition to the frame #17

Open
xorgy opened this issue Sep 14, 2024 · 1 comment
Open

Move frame interval from the Composition to the frame #17

xorgy opened this issue Sep 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@xorgy
Copy link
Member

xorgy commented Sep 14, 2024

Real displays don't follow exact fraction-of-a-second frame rates, and animations are rarely authored with continuous frames on a fixed interval anyhow (whether they are tweened or stop-motion), so the correct place for frame intervals is on the frames/tweens, and not the composition as a whole. Re-pacing animations is a separate concern.

@xorgy
Copy link
Member Author

xorgy commented Sep 14, 2024

There are design considerations for this. To avoid seams between synchronized animations, and edge cases where a frame is rendered without a layer that is expected to be there, but is not due to different rounding: it is still desirable to have integer times at the frame and layer level, so a Composition-level (integer fraction) time base may still be there.

@xorgy xorgy added the enhancement New feature or request label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant