Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include blobs in chain info query responses #2301

Open
Tracked by #1981
ndr-ds opened this issue Jul 24, 2024 · 3 comments
Open
Tracked by #1981

Don't include blobs in chain info query responses #2301

ndr-ds opened this issue Jul 24, 2024 · 3 comments
Assignees
Milestone

Comments

@ndr-ds
Copy link
Contributor

ndr-ds commented Jul 24, 2024

#2220 (comment)

@ndr-ds
Copy link
Contributor Author

ndr-ds commented Nov 12, 2024

We need to make it so that you can't have a ChainInfoQuery return more than 1 of the following 3 at the same time:

  • ChainManager's proposed -> should be fine to return the whole BlockProposal after we add the limits on Fix storage DOS attack in block proposals #2199
  • ChainManager's proposed_blobs -> Same as above
  • ChainManager's locked_blobs -> This one might have published and read blobs, so we need to implement a custom way of returning the locked blobs: maybe sending the blobs one by one and the caller can aggregate them. This could technically also be solved by streaming the blobs as the response.

@afck
Copy link
Contributor

afck commented Nov 12, 2024

Yes, I think the ChainInfoQuery should have a field like request_locked_blob: Option<BlobId> or maybe request_locked_blobs: Vec<BlobId>.

@ndr-ds
Copy link
Contributor Author

ndr-ds commented Nov 12, 2024

We could technically do request_locked_blobs and calculate how many we can request at once based on the current blob size limit and gRPC message size limit 🤔 so we minimize the amount of chain info queries we do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants