Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow association between notifiers and clusters #610

Open
reiabreu opened this issue Jan 29, 2020 · 1 comment
Open

Allow association between notifiers and clusters #610

reiabreu opened this issue Jan 29, 2020 · 1 comment

Comments

@reiabreu
Copy link

Once notification thresholds and (and blacklist/whitelist) conditions are met, all notifiers will emit a notification.
However, this might not be the desired behaviour for all the cases. An example:

  • Burrow is watching clusters C1 and C2
  • Notifiers N1 and N2 are defined. N1 triggers a PagerDuty alert to the team that manages C1. N2 triggers a PagerDuty alert to the team that manages C2
  • Consumer group CG1 is present on both N1 and N2. Once notification conditions are met on either cluster for CG1, N1 and N2 will be triggered, notifying one of the teams with a false positive.

If the notifiers configurations allow an association between cluster and notifier, we can have a default behaviour of triggering all Notifiers and the option of having C1 tied to N1 and C2 tied to N2.
We can reuse the tag cluster to allow this. I've tested modifications to the code and it's doable, since ConsumerGroupStatus carries the cluster name.

@reiabreu
Copy link
Author

#611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant