Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLMSuite needs a refactoring to limit the tasks it tries to do #25

Open
timyitong opened this issue Mar 31, 2016 · 2 comments
Open

GLMSuite needs a refactoring to limit the tasks it tries to do #25

timyitong opened this issue Mar 31, 2016 · 2 comments
Labels
enhancement

Comments

@timyitong
Copy link
Contributor

Different tasks GLMSuite is trying to do should be put into separate places. This class currently takes on too much responsibility.
@XianXing
Copy link
Contributor

One more thing I noted from #74 is that, currently the feature size and the data size empty checks are coupled together in GLMSuite.

May be we should consider to decouple them during the refactoring.

@ashelkovnykov
Copy link
Contributor

GLMSuite is slated for removal - will close this issue after it's gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timyitong @XianXing @ashelkovnykov