Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][venice-router] Add store d2 discovery metric #1408

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hsuttong
Copy link

@hsuttong hsuttong commented Dec 19, 2024

This PR introduces changes to the MetaDataHandler class in the venice-router component to add a metric to track client D2 discovery of stores. Additionally, it updates the corresponding test class to accommodate these changes.

Resolves #1407

How was this PR tested?

Tested in CI and successfully ran these test locally:

gradlew clean -DmaxParallelForks=2  --parallel -x :internal:venice-avro-compatibility-test:test jacocoTestCoverageVerification diffCoverage --continue
gradlew --continue --no-daemon -DmaxParallelForks=2 --parallel -Pspotallbugs check -x spotlessCheck -x test -x integrationTest -x jacocoTestCoverageVerification

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@hsuttong hsuttong changed the title [venice-router] Add store discovery metric [venice-router] Add store d2 discovery metric Dec 19, 2024
@hsuttong hsuttong changed the title [venice-router] Add store d2 discovery metric [WIP][venice-router] Add store d2 discovery metric Dec 20, 2024
@hsuttong hsuttong marked this pull request as ready for review December 20, 2024 00:21
@hsuttong hsuttong marked this pull request as draft December 20, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add new metric to capture client store connection.
1 participant