Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class OnvifClientDevice's member variable may be protected, instead of private. #14

Open
mitshan1994 opened this issue Aug 6, 2019 · 0 comments

Comments

@mitshan1994
Copy link

When someone want to change struct soap attribute, such as soap::connect_timeout to get a more friendly experience when destination port is closed, there are no means to achieve this, because OnvifClientDevice class member variable DeviceBindingProxy deviceBindProxy; is private, and no method to get/set it. I think make these variable protected, and we can then inherit class OnvifClientDevice to custom soap attribute through DeviceBindingProxy deviceBindProxy; I do think this will make library more extendable or is there any problem I didn't consider?
Appreciate your answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant