Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make clean_build/make uninstall don't work #20

Open
Coloquinte opened this issue Aug 11, 2023 · 1 comment
Open

make clean_build/make uninstall don't work #20

Coloquinte opened this issue Aug 11, 2023 · 1 comment
Assignees
@robtaylor

Comments

@Coloquinte
Copy link
Collaborator

We don't have the right path when calling clean_build or uninstall. This is because it uses INST_ROOT/ISYS_ROOT, which are not correct from there.

  • clean_build removes ~/coriolis-2.x/src/../build, should be ~/coriolis-2.x/Linux.x86_64/Release.Shared/build/
  • uninstall removes ~/coriolis-2.x/src/Linux.x86_64, should be ~/coriolis-2.x/Linux.x86_64/Release.Shared/install/

It cannot be simply remedied by changing how we compute the path in bootstrap/coriolisEnv.py, as it needs to remain correct to setup the environment when called from the installed coriolis. So for now it's a manual cleanup
@robtaylor
Copy link
Collaborator

when #29 is complete, this should solve this issue

@robtaylor robtaylor self-assigned this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robtaylor robtaylor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robtaylor @Coloquinte