Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonise user & process configuration #66

Open
robtaylor opened this issue Oct 14, 2023 · 2 comments
Open

Pythonise user & process configuration #66

robtaylor opened this issue Oct 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed pythonisation

Comments

@robtaylor
Copy link
Collaborator

There are a lot of places where configuration is loaded by looking for .py files in various places, using various strategies. This is very unpythonic, and problematic in multiple ways, especially for folk using coriolis as a library.

These need a good overview and ideally a bit of a plan writing up before implementation.

Relevent issue: #63
also places where exec is used:

bootstrap/builder/Configuration.py:            exec( open(self._confFile).read(), globals() )
bora/python/initHook.py:            exec( open(userInit).read() )
crlcore/python/helpers/__init__.py:            exec(open( technoFile ).read())  # moduleGlobals
katana/python/initHook.py:            exec( open(userInit).read() )

Also any code referencing 'CORIOLIS_TOP'/'coriolis_top'

crlcore/src/ccore/Utilities.cpp
crlcore/src/pyCRL/PyCRL.cpp
cumulus/src/designflow/task.py
cumulus/src/designflow/technos.py
flute/src/3.1/PyFlute.cpp
katana/src/KatanaEngine.cpp
unicorn/src/coriolis.py

@jpc-lip6
Copy link
Collaborator

jpc-lip6 commented Oct 14, 2023

This is an aftermath of the migration of Coriolis from C++ with Python scripts to Python modules with C++ code.
As the move in itself was not completely understood/assumed at the time we got this "intermediate" situation.

So, yes, a clear policy should be defined. Nevertheless, I am afraid some unpythonic parts may have to stay due to the very nature of the software.

@robtaylor robtaylor added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed pythonisation labels Oct 14, 2023
@robtaylor
Copy link
Collaborator Author

This is an aftermath of the migration of Coriolis from C++ with Python scripts to Python modules with C++ code. As the move in itself was not completely understood/assumed at the time we got this "intermediate" situation.

So, yes, a clear policy should be defined. Nevertheless, I am afraid some unpythonic parts may have to stay due to the very nature of the software.

Which bits are you thinking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed pythonisation
Projects
None yet
Development

No branches or pull requests

3 participants