Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent column renames from collisions with a check in Phase over all its columns #17

Open
lisad opened this issue Jan 5, 2024 · 1 comment · May be fixed by #174
Open

Prevent column renames from collisions with a check in Phase over all its columns #17

lisad opened this issue Jan 5, 2024 · 1 comment · May be fixed by #174
Assignees
@lisad

Comments

@lisad
Copy link
Owner

lisad commented Jan 5, 2024 

    # LMDTODO: Add a check in PHase.__init__ to check if any of the column renames collide.
    # For example you can't rename 'div' to both "Division" and "Divisor"
lisad added a commit that referenced this issue Jun 2, 2024
@lisad
Adds a test for issue #17 and fixes comment about ReshapePhase which …
d59e95f 
…is now gone
@lisad
Copy link
Owner Author

lisad commented Jun 2, 2024

There's now a test to demonstrate how this OUGHT to work - test_columns.py::test_conflicting_renames
@YuliaS this would be a good one

lisad added a commit that referenced this issue Jun 4, 2024
@lisad
Merge pull request #136 from lisad/test-conflicting-renames
f74f64c 
Adds a test for issue #17 and fixes comment referencing ReshapePhase
@lisad lisad self-assigned this Oct 16, 2024
@lisad lisad linked a pull request Oct 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lisad lisad

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lisad