Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc-XXX is not valid perl 6 method name #31

Closed
AlexDaniel opened this issue Oct 15, 2016 · 2 comments
Closed

irc-XXX is not valid perl 6 method name #31

AlexDaniel opened this issue Oct 15, 2016 · 2 comments

Comments

@AlexDaniel
Copy link
Contributor

https://github.com/zoffixznet/perl6-IRC-Client/blob/029c43c63b938c991a10cf27eb75907bc6d8623e/lib/IRC/Client.pm6#L270

For example, in this comment it was recommended to use irc_353, but as far as I can see the actual method name is irc-353.

Unless I misunderstand something, it should be called “irc-n353” or something like that.

@zoffixznet
Copy link
Contributor

I guess it tells you how thorough the test suite for this module is 😂

@AlexDaniel
Copy link
Contributor Author

It's not that bad, there are several live test suites running on #perl6 :P

In fact, we have tests for whateverables, so we test IRC::Client indirectly as well (a bit).

But yes, this:

-                take 'irc-' ~ $e.command, $event-name;
+                take 'irc-n' ~ $e.command, $event-name;

Solves the problem for me. But of course, it needs documentation changes and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants