Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The call to make-array to make-sharable-array on Lispworks in broken. #8

Open
Yehouda opened this issue Feb 1, 2022 · 2 comments
Open

Comments

@Yehouda
Copy link

Yehouda commented Feb 1, 2022

(apply #'make-array

It currentll passes the :allocation :static kwyord before the arguments, including the dimensions required argument. That is the wrong syntax, the required argumnet must come first. I fixed it in my copy by chaging to:

(apply #'make-array
         (car args)
	 #+(or lispworks allegro) :allocation
	 #+lispworks :static #+allegro :static-reclaimable
	 (cdr args))

That is working on LispWorks. Probably on Allegro too, but I didn't check.

Found by running the tests of the quicklisp system "dataloader.test".

@ljosa
Copy link
Owner

ljosa commented Feb 1, 2022

Good catch! Are you up for putting together a pull request?

@Yehouda
Copy link
Author

Yehouda commented Feb 1, 2022

No.
I test code that I load by quicklisp, and don;t work on github. I come here (github) only to hassle people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants