Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][CallGraph] Missed visibility for CallGraphNode to construct AbstractEdge #115437

Open
Luhaocong opened this issue Nov 8, 2024 · 2 comments
Labels

Comments

@Luhaocong
Copy link
Contributor

Luhaocong commented Nov 8, 2024

Hi River @River707 @tensorflower-gardener ,In CallGraph Analysis, I find a AbstractEdge will always be added to target CallGraphNode from externalCallerNode, no matter the target is a public or private FunctionOpInterface (which is derived class of CallableOpInterface) .

// Otherwise, connect all callable nodes to the external node, this allows
// for conservatively including all callable nodes within the graph.
// FIXME This isn't correct, this is only necessary for callable nodes
// that *could* be called from external sources. This requires extending
// the interface for callables to check if they may be referenced
// externally.
externalCallerNode.addAbstractEdge(node.get());

Is there any plan to add visibility for CallableOpInterface to get better analysis result ?Or could you please give me some advice, I can try to fix this problem?

@github-actions github-actions bot added the mlir label Nov 8, 2024
@jacquesguan jacquesguan pinned this issue Nov 8, 2024
@jacquesguan jacquesguan unpinned this issue Nov 8, 2024
@Luhaocong
Copy link
Contributor Author

move to #116177

@EugeneZelenko
Copy link
Contributor

Not merged yet.

@EugeneZelenko EugeneZelenko reopened this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants