Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimation fails if finalizeEpoch epoch is finalized far from epochEnd. #124

Closed
3esmit opened this issue Sep 20, 2024 · 0 comments · Fixed by #127
Closed

Estimation fails if finalizeEpoch epoch is finalized far from epochEnd. #124

3esmit opened this issue Sep 20, 2024 · 0 comments · Fixed by #127
Assignees
@3esmit
Milestone
Staking V1

Comments

@3esmit
Copy link
Collaborator

3esmit commented Sep 20, 2024

The estimation math considers that epochs will be exactly EPOCH_SIZE, when an epoch is finalized after epochEnd (epoch.startTime + EPOCH_SIZE), the estimation fails.

To fix this, the epoch[currentEpoch].startTime should always be the epoch[currentEpoch-1].startTime + EPOCH_SIZE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3esmit 3esmit

Labels
None yet
Projects
None yet
Milestone
Staking V1
Development

Successfully merging a pull request may close this issue.

fix(StakeManager): fix finalizeEpoch to use last epoch epochEnd logos-co/staking
2 participants
@3esmit @0x-r4bbit