From 0b22c15c0a76aa70597d0cb7df4c101d04b27b35 Mon Sep 17 00:00:00 2001 From: James Munson Date: Mon, 11 Sep 2023 13:16:19 -0600 Subject: [PATCH] Changes requested in PR review. Signed-off-by: James Munson --- .../docs/1.5.0/references/storage-class-parameters.md | 4 ++-- .../docs/1.5.1/references/storage-class-parameters.md | 4 ++-- .../docs/1.5.2/references/storage-class-parameters.md | 4 ++-- content/docs/1.6.0/references/settings.md | 10 +++++++--- .../docs/1.6.0/references/storage-class-parameters.md | 4 ++-- 5 files changed, 15 insertions(+), 11 deletions(-) diff --git a/content/docs/1.5.0/references/storage-class-parameters.md b/content/docs/1.5.0/references/storage-class-parameters.md index cfe9c444b..11ba63995 100644 --- a/content/docs/1.5.0/references/storage-class-parameters.md +++ b/content/docs/1.5.0/references/storage-class-parameters.md @@ -193,9 +193,9 @@ A list of recurring jobs that are to be run on a volume. > More details in [Scheduling](../../volumes-and-nodes/scheduling). #### Backend Store Driver *(field: `parameters.backendStoreDriver`)* -> Default: `""` +> Default: `"v1"` - - Use "spdk" to run the v2 SPDK-based engine. + - Use "v2" to run the v2 SPDK-based engine (experimental in 1.5.) If empty, "v1" is assumed. > Global setting: [V2 Data Engine](../settings#v2-data-engine). > More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass). diff --git a/content/docs/1.5.1/references/storage-class-parameters.md b/content/docs/1.5.1/references/storage-class-parameters.md index cfe9c444b..11ba63995 100644 --- a/content/docs/1.5.1/references/storage-class-parameters.md +++ b/content/docs/1.5.1/references/storage-class-parameters.md @@ -193,9 +193,9 @@ A list of recurring jobs that are to be run on a volume. > More details in [Scheduling](../../volumes-and-nodes/scheduling). #### Backend Store Driver *(field: `parameters.backendStoreDriver`)* -> Default: `""` +> Default: `"v1"` - - Use "spdk" to run the v2 SPDK-based engine. + - Use "v2" to run the v2 SPDK-based engine (experimental in 1.5.) If empty, "v1" is assumed. > Global setting: [V2 Data Engine](../settings#v2-data-engine). > More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass). diff --git a/content/docs/1.5.2/references/storage-class-parameters.md b/content/docs/1.5.2/references/storage-class-parameters.md index cfe9c444b..11ba63995 100644 --- a/content/docs/1.5.2/references/storage-class-parameters.md +++ b/content/docs/1.5.2/references/storage-class-parameters.md @@ -193,9 +193,9 @@ A list of recurring jobs that are to be run on a volume. > More details in [Scheduling](../../volumes-and-nodes/scheduling). #### Backend Store Driver *(field: `parameters.backendStoreDriver`)* -> Default: `""` +> Default: `"v1"` - - Use "spdk" to run the v2 SPDK-based engine. + - Use "v2" to run the v2 SPDK-based engine (experimental in 1.5.) If empty, "v1" is assumed. > Global setting: [V2 Data Engine](../settings#v2-data-engine). > More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass). diff --git a/content/docs/1.6.0/references/settings.md b/content/docs/1.6.0/references/settings.md index acd5b6a5a..12a87fc59 100644 --- a/content/docs/1.6.0/references/settings.md +++ b/content/docs/1.6.0/references/settings.md @@ -577,7 +577,10 @@ When this setting is un-checked, the Longhorn Manager will schedule replicas on When this setting is checked, the Longhorn Manager will allow scheduling on nodes with existing healthy replicas of the same volume. -When this setting is un-checked, the Longhorn Manager will not allow scheduling on nodes with existing healthy replicas of the same volume. +When this setting is un-checked, Longhorn Manager will forbid scheduling on nodes with existing healthy replicas of the same volume. + +> **Note:** +> - This setting is superseded if replicas are forbidden to share a zone by the Replica Zone Level Anti-Affinity setting. #### Replica Zone Level Soft Anti-Affinity @@ -585,7 +588,7 @@ When this setting is un-checked, the Longhorn Manager will not allow scheduling When this setting is checked, the Longhorn Manager will allow scheduling new replicas of a volume to the nodes in the same zone as existing healthy replicas. -When this setting is un-checked, Longhorn Manager will not allow scheduling new replicas of a volume to the nodes in the same zone as existing healthy replicas. +When this setting is un-checked, Longhorn Manager will forbid scheduling new replicas of a volume to the nodes in the same zone as existing healthy replicas. > **Note:** > - Nodes that don't belong to any zone will be treated as if they belong to the same zone. @@ -597,10 +600,11 @@ When this setting is un-checked, Longhorn Manager will not allow scheduling new When this setting is checked, the Longhorn Manager will allow scheduling new replicas of a volume to the same disks as existing healthy replicas. -When this setting is un-checked, Longhorn Manager will not allow scheduling new replicas of a volume to the same disks as existing healthy replicas. +When this setting is un-checked, Longhorn Manager will forbid scheduling new replicas of a volume to the same disks as existing healthy replicas. > **Note:** > - Even if the setting is "true" and disk sharing is allowed, Longhorn will seek to use a different disk if possible, even if on the same node. +> - This setting is superseded if replicas are forbidden to share a zone or a node by either of the other Soft Anti-Affinity settings. #### Replica Auto Balance diff --git a/content/docs/1.6.0/references/storage-class-parameters.md b/content/docs/1.6.0/references/storage-class-parameters.md index e12e02c04..3a6b63dba 100644 --- a/content/docs/1.6.0/references/storage-class-parameters.md +++ b/content/docs/1.6.0/references/storage-class-parameters.md @@ -203,9 +203,9 @@ A list of recurring jobs that are to be run on a volume. > More details in [Scheduling](../../volumes-and-nodes/scheduling). #### Backend Store Driver *(field: `parameters.backendStoreDriver`)* -> Default: `""` +> Default: `"v1"` - - Use "spdk" to run the v2 SPDK-based engine. + - Use "v2" to run the v2 SPDK-based engine (experimental in 1.6.) If empty, "v1" is assumed. > Global setting: [V2 Data Engine](../settings#v2-data-engine). > More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass).