Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rewindOnResize: false" doesn't work when "infinite: 1" #433

Open
gustavopch opened this issue Oct 3, 2016 · 4 comments
Open

"rewindOnResize: false" doesn't work when "infinite: 1" #433

gustavopch opened this issue Oct 3, 2016 · 4 comments
Assignees
Labels

Comments

@gustavopch
Copy link

gustavopch commented Oct 3, 2016

First, thanks @meandmax and contributors. This package is great.

Second, as the title says, I think I found a bug.
"rewindOnResize: false" doesn't work when "infinite: 1"

Here it is: http://codepen.io/anon/pen/LROxGv

@nstanard
Copy link
Collaborator

nstanard commented Oct 4, 2016

Here is a working example with rewindOnResize set to false.

http://codepen.io/nstanard/pen/amVwvR?editors=1010
I think it's mentioned in the docs somewhere that infinite doesn't work with some other options.

@gustavopch
Copy link
Author

It's written in the docs that infinite doesn't combine with rewind. So having infinite enabled but setting rewindOnResize to false shouldn't be a problem, right? Because it would exactly avoid rewind.

@nstanard
Copy link
Collaborator

nstanard commented Oct 4, 2016

Yea that's true, it only calls out rewind. I have a couple other changes I want to make myself to the rewind functionality so I'll try to take a look at that too.

@nstanard nstanard added the bug label Dec 13, 2016
@nstanard nstanard self-assigned this Dec 13, 2016
@benjibee
Copy link

This is still an issue on our site. I've done some tooling around to no avail. It's not mentioned above, but it's also really evident on mobile, and looks quite janky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants