Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused code cleanup #282

Open
cniethammer opened this issue Feb 8, 2024 · 1 comment
Open

Unused code cleanup #282

cniethammer opened this issue Feb 8, 2024 · 1 comment
Labels
good first issue Good for newcomers WIP Work In Progress

Comments

@cniethammer
Copy link
Contributor

Get rid of interfaces, methods, and functions that are not used anymore.

This should help improve code readability, compile times, and reduce binary size if compilers cannot optimize stuff away.

@HomesGH
Copy link
Contributor

HomesGH commented Feb 9, 2024

This issue is a good idea! There is a lot of mess in the code, especially regarding the thermostats, e.g. here and here. For the latter: Why is the warning only printed if unit tests are disabled? This FIXME for the thermostat is a bit worrying as this is in a central part of the code.

Also some output like this seems to be outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers WIP Work In Progress
Projects
None yet
Development

No branches or pull requests

2 participants