Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools_scm 8 has changed write_to to version_file #362

Closed
erykoff opened this issue Sep 21, 2023 · 3 comments
Closed

setuptools_scm 8 has changed write_to to version_file #362

erykoff opened this issue Sep 21, 2023 · 3 comments

Comments

@erykoff
Copy link
Contributor

erykoff commented Sep 21, 2023

The pyproject.toml on rubin_sim uses write_to to create the version file. But this has been changed with setuptools_scm version 8: https://github.com/pypa/setuptools_scm/blob/main/CHANGELOG.rst#v800

So the version of setuptools_scm needs to be pinned at < 8, and/or the new API needs to be used. The rubin_sim_feedstock needs corresponding changes.

I have no idea if it's possible to support both versions at the same time. Fun!

@rmjarvis
Copy link

rmjarvis commented Sep 22, 2023

They're up to 8.0.3 now. I haven't checked whether things work with this version, but they presumably got a lot of complaints about their breaking change...

https://github.com/pypa/setuptools_scm/blob/main/CHANGELOG.md

@rhiannonlynne
Copy link
Member

I tried updating to what should work with version 8, and it still doesn't create a version file.
So for now, I guess I'll stick with pinning the version.

@rhiannonlynne
Copy link
Member

Should be resolved with #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants