Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/transactions/sign doesn't return a signature when sender is missing #155

Open
sbrekelmans opened this issue Jun 8, 2022 · 1 comment
Open

Comments

@sbrekelmans
Copy link

sbrekelmans commented Jun 8, 2022

When submitting an unsigned transaction, a "signed" transaction is returned that doesn't contain proofs

After receiving help - it seems I was missing the "sender" address field. The endpoint doesn;t return an error however, it just returns a 200 and a transaction without a proof.

To reproduce, this is the body sent to the endpoint:

{
"type": 4,
"fee": 100000000,
"amount": 1000000000,
"recipient": "",
"senderPublicKey": ""
}

it returns a (200) with a transaction, but missing the "proofs" parameter. I would expect an error.

@sbrekelmans
Copy link
Author

Suggestions:

  • return a validation error
  • add example schema's to the swagger for all POST requests, this would make developing much easier.

@jasny jasny changed the title /transactions/sign doesn't return a signature /transactions/sign doesn't return a signature when sender is missing Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant