Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting non-poetry projects #171

Open
1 task
AbdealiLoKo opened this issue Sep 28, 2023 · 0 comments
Open
1 task

Supporting non-poetry projects #171

AbdealiLoKo opened this issue Sep 28, 2023 · 0 comments
Labels
enhancement New feature or request needs-triage This issue needs triage

Comments

@AbdealiLoKo
Copy link

  • I'd be willing to implement this feature

Description

I do not use poetry as of now, and just use normal python with a central venv.

So, I have a project structure as:

apps/
    my-pkg/
        project.json
        mypkg/
             __init__.py
        tests/
             __init__.py
    my-pkg2/
        project.json
        mypkg2/
             __init__.py
        tests/
             __init__.py

And in my project.json I have something like:

{
  "projectType": "application",
  "targets": {
    "install": {
      "executor": "nx:run-commands",
      "options": {
        "command": "python -m venv venv && venv/bin/pip install -e {projectRoot}"
      }
    },
    "lint": {
      "executor": "nx:run-commands",
      "options": {
        "commands": [
          "venv/bin/ruff {projectRoot}",
          "venv/bin/black --config .black.toml --check {projectRoot}",
          "node_modules/.bin/prettier --check {projectRoot}"
        ]
      }
    },
   ...
}

I would love to make this more "nx-ey" instead of using nx in this hacky way of just running commands for me.
I am trying to figure out if your python plugin could be used to handle this - or not ?

Motivation

Looking to clean up the way I use nx to leverage nx better.
I have tried https://github.com/hogarthww-labs/nx-python
and https://github.com/nx-python/PyNX
both seem to be unmaintained.

Suggested Implementation

Not sure - if there is a clear pat in your mind, I can spend some time in trying to implement it.
But note that I am pretty new to nx pugins...

Alternate Implementations

Keep using run-commands 😞

@AbdealiLoKo AbdealiLoKo added enhancement New feature or request needs-triage This issue needs triage labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage This issue needs triage
Projects
None yet
Development

No branches or pull requests

1 participant