Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline query support #32

Open
freeseacher opened this issue Jan 5, 2016 · 9 comments
Open

inline query support #32

freeseacher opened this issue Jan 5, 2016 · 9 comments

Comments

@freeseacher
Copy link

according to latest api changes please add inline query support to your api
https://core.telegram.org/bots/inline
tnx!

@lukefx
Copy link
Owner

lukefx commented Jan 5, 2016

Yepp...on my to do list :) maybe today or tomorrow

On Tuesday, January 5, 2016, Aleksey Shirokih [email protected]
wrote:

according to latest api changes please add inline query support to your api
https://coretelegramorg/bots/inline
tnx!


Reply to this email directly or view it on GitHub
#32.

@arcturial
Copy link
Collaborator

Let me know if you need help on this @lukefx, might need to do some refactoring to support it with minimal code duplication.

@lukefx
Copy link
Owner

lukefx commented Jan 6, 2016

@arcturial yepp thx, first of all, what do you think for the inlineQuery initial request? https://core.telegram.org/bots/api#inlinequery we should manage the request within the telegrambot api and launch and event to the adapter? What do you think?

@arcturial
Copy link
Collaborator

All the telegrambot API does is interact with the getUpdate method and sends the result to the callback, so not sure it would be the best place to put the events. However, we can change the code at line 212 and 225 to call handleInlineQuery if the inline_query key is set and then abstracting all the "common tasks" into different methods.

@lukefx
Copy link
Owner

lukefx commented Jan 6, 2016

All the telegrambot API does is interact with the getUpdate method and sends the result to the callback, so not sure it would be the best place to put the events. However, we can change the code at line 212 and 225 to call handleInlineQuery if the inline_query key is set and then abstracting all the "common tasks" into different methods.

I was thinking a method to let user define what the bot should reply to the inlinquery, so yes, quick and dirty could be in the handleUpdate method add an if and check if the message starts with a "@" and then? send an event so you can catch it in a script and compose your reply...

Anyway, let's create a branch...and collaborate on it...code speak itself 😄

@freeseacher
Copy link
Author

the text will not starts with @
i had already seen it.
instead of it you will have the inline_query object with text in it

ср, 6 янв. 2016 г. в 16:45, Luca Simone [email protected]:

All the telegrambot API does is interact with the getUpdate method and
sends the result to the callback, so not sure it would be the best place to
put the events. However, we can change the code at line 212 and 225 to call
handleInlineQuery if the inline_query key is set and then abstracting all
the "common tasks" into different methods.

I was thinking a method to let user define what the bot should reply to
the inlinquery, so yes, quick and dirty could be in the handleUpdate method
add an if and check if the message starts with a "@" and then? send an
event so you can catch it in a script and compose your reply...

Anyway, let's create a branch...and collaborate on it...code speak itself [image:
😄]


Reply to this email directly or view it on GitHub
#32 (comment)
.

@lukefx
Copy link
Owner

lukefx commented Jan 6, 2016

Ah ok...so how do we know if is an inline query? By the object's attributes?

#33 I've created a branch for this...

@arcturial
Copy link
Collaborator

Teap, the object attributes we get in getUpdates are different. Like @freeseacher said, it will contain the inline_query key with the text of the command inside inline_query.query.

@C3realGuy
Copy link

C3realGuy commented Sep 23, 2016

any news on this?
Would love to see that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants