-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v2 transaction format #1
Comments
Hi @OndrejHRIC, as of now, since this is an unofficial 3rd-party library, transaction v2 support has not yet been implemented. However, this would certainly be nice to have, and any community contributions are welcome! |
I've completed most of the code for v2, but having some issues testing. Can we get together and resolve then I'll make a pull request to your for the updates. |
I am able to post onto arlocal. But there's an issue when I get data back and try to decode it into the Transaction type. It seems like it should be an easy issue, but not seeing where the decode is failing. |
Almost there. So I'm able to post a transaction with string data. I'm then able to get back and decode the transaction without the data. Now when I try and get just the data the data does come back but when it decodes into string its empty.
|
Ok I resolved the issues. Contact me if you want a pull |
@jsoneaday Awesome work! I'd love to incorporate this feature. Can you submit a PR? |
Referencing PR #7 Current status of this work on branch: https://github.com/lukereichold/arweave-swift/tree/add-formatv2 Remaining TODOs:
Once those get added then we can safely merge these changes. |
I've been testing on production, arweave.net and its failing. I did some fixes sign function but it looks like the signatureBody is now the issue. I suspect it is on the data_root field which is derived from the prepareChunks function but not sure exactly. |
Hey @OndrejHRIC I'm pretty close to done with the updates, but having one remaining issue with generating signatures. @lukereichold is busy. Would you like to take a stab at it? I'm pretty sure this is the last issue and then I'll do a pull request to merge! |
Xcode 12.0 (12A7209)
iOS 14.0 / 13.7
Arweave 1.0.2
I'm not able to upload data over 10MB size. I was told that tx format v2 is able to handle data size over 10MB but there is no mention of it. How should I use v2? Thanks in advance.
The text was updated successfully, but these errors were encountered: