Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socklen_t already defined on mingw32-w32api-dev 5.3 #158

Open
DarkWiiPlayer opened this issue Mar 29, 2020 · 5 comments
Open

socklen_t already defined on mingw32-w32api-dev 5.3 #158

DarkWiiPlayer opened this issue Mar 29, 2020 · 5 comments

Comments

@DarkWiiPlayer
Copy link

This is pretty much the same issue as luasocket has.

MinGWs ws2tcpip.h now defines socklen_t since the last version, causing an error when Luarocks tries to compile the .c files when installing luasec.

@DarkWiiPlayer
Copy link
Author

Update: a possible fix for this is currently (not) being discussed on the luasocket repository here: lunarmodules/luasocket#303

@ewestbrook
Copy link
Contributor

I don't know why you'd say "(not)". LuaSocket would like to do the right thing for users of new mingw32 versions without doing the wrong thing for users of earlier mingw32 versions. I'd imagine that LuaSec wants the same. If anyone has a good #ifdef for that, please share.

@DarkWiiPlayer
Copy link
Author

DarkWiiPlayer commented Apr 8, 2020

Well, there's not really a discussion going on, which is precisely why linked it here. The way I understand it, nobody really knows an ideal way to deal with this and just deleting the typedef altogether as in my pull request may end up breaking the library on some other system. I'm not complaining that luasocket isn't instantly fixing this, I'm just annoyed that none of the users care enough to add to the discussion.

I imagine the best way to get this fixed quickly is having more feedback from users on "weird" systems with old or patched versions of MinGW, outdated windows versions, etc.

@limjiregister
Copy link

How to fix this issues quickly?

@brunoos
Copy link
Member

brunoos commented Jun 3, 2020

I need to setup an environment to reproduce this issue.
I need to find a Windows machine and if you can help me with mingw...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants