Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept 429 code not taken in account #1340

Closed
nvuillam opened this issue Jan 7, 2024 · 5 comments · Fixed by #1344
Closed

accept 429 code not taken in account #1340

nvuillam opened this issue Jan 7, 2024 · 5 comments · Fixed by #1344

Comments

@nvuillam
Copy link

nvuillam commented Jan 7, 2024

With 0.14.0

lychee.toml contains

# Comma-separated list of accepted status codes for valid links.
accept = ["200", "206", "429"]

But results considers as errors 429 status codes

....
  ✗ [429] https://github.com/bdovaz | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/cgbosse | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/oxsecurity/megalinter/tree/main/docs/descriptors/editorconfig.md | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/oxsecurity/megalinter/tree/main/docs/descriptors/json_jsonlint.md | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/oxsecurity/megalinter/blob/main/docs/assets/images/GitHubCommentReporter.jpg?raw=true%3E | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/terraform-linters/tflint | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/oxsecurity/megalinter/tree/main/docs/descriptors/vbdotnet_dotnet_format.md | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/oxsecurity/megalinter/tree/main/docs/descriptors/go.md | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/oxsecurity/megalinter/tree/main/docs/config-postcommands.md | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/oxsecurity/megalinter/tree/main/docs/descriptors/html_htmlhint.md | Failed: Network error: Too Many Requests
  ✗ [429] https://github.com/super-linter/super-linter/pulls?q=is%3Apr+is%3Aclosed+author%3Anvuillam+review%3Aapproved | Failed: Network error: Too Many Requests

....

  📝 Summary
  ---------------------
  🔍 Total.........2290
  ✅ Successful....1441
  ⏳ Timeouts.........0
  🔀 Redirected.......0
  👻 Excluded.......425
  ❓ Unknown..........0
  🚫 Errors.........424
nvuillam added a commit to oxsecurity/megalinter that referenced this issue Jan 7, 2024
nvuillam added a commit to oxsecurity/megalinter that referenced this issue Jan 7, 2024
* [automation] Auto-update linters version, help and documentation

* Fix lychee breaking change

Upgrade lychee default configuration to handle [breaking change between 0.13.0 and 0.14.0](lycheeverse/lychee#1338)

* Undowngrade revive

* Fix lychee config until bug is solved

lycheeverse/lychee#1340

* [MegaLinter] Apply linters fixes

---------

Co-authored-by: nvuillam <[email protected]>
Co-authored-by: nvuillam <[email protected]>
@mre
Copy link
Member

mre commented Jan 7, 2024

@Techassi, any ideas?

@Techassi
Copy link
Contributor

Techassi commented Jan 7, 2024

Well, this seems rather interesting. I will look into it.

@Techassi
Copy link
Contributor

Techassi commented Jan 8, 2024

This will be fixed by #1344.

This is a one-line change that took me 1,5h to debug. My first thought was that our parsing is messed up (which it isn't), but the option set in the TOML config file never got used... :/

@nvuillam
Copy link
Author

nvuillam commented Jan 8, 2024

@Techassi great, thanks :)

@mre mre closed this as completed in #1344 Jan 9, 2024
@mre
Copy link
Member

mre commented Jan 10, 2024

New release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants