Missing null query check in query response

[amitds1997]

For an incompatible client, Trino/Presto throw exception :

Basic authentication or X-Trino-User must be sent // Trino
Basic authentication or X-Presto-User must be sent // Presto

and sends no Query Id information.

We are currently submitting the query for addition to Query History without checking if the Query Id is null.

presto-gateway/gateway-ha/src/main/java/com/lyft/data/gateway/ha/handler/QueryIdCachingProxyHandler.java

Line 258 in 39d7d5f

queryHistoryManager.submitQueryDetail(queryDetail);

which leads to an Exception

java.sql.SQLException: Field 'query_id' doesn't have a default value

[endoplasmicR]

this is likely something https://trino.io/blog/2021/01/04/migrating-from-prestosql-to-trino.html has described
and you need to enable "Client protocol compatiblity" on the trino coordinator

[endoplasmicR]

We may consider adding dual HTTP header writes (if eitherX-Presto-... or X-Trino-... is set, both X-Presto-... and X-Trino-...` headers would be send to the coordinators) in the future