Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command is case-sensitive to folder names #22

Open
m-triassi opened this issue Jan 31, 2024 · 0 comments
Open

Remove command is case-sensitive to folder names #22

m-triassi opened this issue Jan 31, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@m-triassi
Copy link
Owner

Description

Files dont get deleted when attemting to deleted them if their case doesn't match the name of the downloaded zip

Expected Behavior

The Regex that searches for the appropriate file should find the folder to delete, regardless of casing, and delete it.

Current Behavior

When folders match the casing of their corresponding zip file, they are deleted as expected. When they do not match the same casing the folder remains in place.

Reproduction Steps

  1. Attempt to add an addon with casing which is mismatched from the extracted file (eg: OmniCD: 306489)
  2. Run the command to remove this addon
  3. Observe that the folder "OmniCD" has not been deleted, as it's case differs from the API returned named "omnicd"

Possible Implementation

The regex which searches for the associated file should be case insensitive, or it the data structure used to store which addons are installed can be made more complex and could store the install path, removing the need for a Regex

@m-triassi m-triassi added the bug Something isn't working label Jan 31, 2024
@m-triassi m-triassi self-assigned this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant