Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Improve check-required workflow #1248

Open
pavlovic-ivan opened this issue Jul 1, 2024 · 7 comments · May be fixed by #1249
Open

[FEATURE REQUEST]: Improve check-required workflow #1248

pavlovic-ivan opened this issue Jul 1, 2024 · 7 comments · May be fixed by #1249
Labels
feature A new feature (or feature request)

Comments

@pavlovic-ivan
Copy link
Contributor

Is your feature request related to a problem? Please describe.

N/A

Describe the solution you'd like

In several other repos we maintain (like Parquetsharp, FML, YHS, Armada), we have the latest version of check-required workflow. This version is a bit more advanced than the currently existing one in ILGPU. I would like to contribute with the improvement of this workflow, so i can, later on, extract it to a common repo, where it would be centralised, and updated regularly, so everyone receives the latest version

Describe alternatives you've considered

No response

Additional context

No response

@pavlovic-ivan pavlovic-ivan added the feature A new feature (or feature request) label Jul 1, 2024
@pavlovic-ivan
Copy link
Contributor Author

@MoFtZ @m4rs-mt how do you feel about this request?

@MoFtZ
Copy link
Collaborator

MoFtZ commented Jul 1, 2024

Sounds like a good idea @pavlovic-ivan 👍 Especially if it makes your life easier.

@pavlovic-ivan
Copy link
Contributor Author

All right, happy to hear that. I will create a PR for you soon

@pavlovic-ivan
Copy link
Contributor Author

There will be some setup required in the settings, if that's ok with you @MoFtZ ? Basically, a Github app needs to be created, and it's app id and private key should be added as secrets to ILGPU settings.

@MoFtZ
Copy link
Collaborator

MoFtZ commented Jul 1, 2024

There will be some setup required in the settings

This will need to be handled by @m4rs-mt 🥰

@pavlovic-ivan pavlovic-ivan linked a pull request Jul 1, 2024 that will close this issue
3 tasks
@m4rs-mt
Copy link
Owner

m4rs-mt commented Jul 18, 2024

I'm back and happy to do what is required in the next days! Will connect with you offline to get things going @pavlovic-ivan

@pavlovic-ivan
Copy link
Contributor Author

Sounds good @m4rs-mt , let's sync offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature (or feature request)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants