Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue when using multipe aws components where one doesn't have endpoints #221

Open
bluedread opened this issue Mar 14, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@bluedread
Copy link

Is your proposal related to a problem?

We had a config with multiple AWS site components. One of those doesn't use endpoints:

sites:
  - identifier: tst-aap
    endpoints:
      internal:
        url: some.url
        ...
      external:
        url: another.url
        aws:
          ...
  - identifier: tst-noot
    aws:
      ...

There were componentes deployed to the tst-aap site that used endpoints, and components to tst-noot that didn't use endpoints. When deploying with mach composer version 2.2 this worked.

When switching to 2.8 this generated an error:

| Error: An error occured:
|
| failed to render resources: plugin aws failed to render resources: aws component requires undeclared endpoint: internal

Describe the solution you'd like

It should be possible to deploy components that don't require an endpoint to a site that doesn't use those, while keeping different aws sites in the same configuration yaml file.

Describe alternatives you've considered

We've split up the configuration into multiple files, this unblocked us.

Additional context

@pimvernooij pimvernooij added the bug Something isn't working label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants