Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to extend or overwrite cloud resource tags #58

Open
tleguijt opened this issue Dec 17, 2020 · 3 comments
Open

Provide ability to extend or overwrite cloud resource tags #58

tleguijt opened this issue Dec 17, 2020 · 3 comments
Labels
discussion Tickets that are open for discussion enhancement New feature or request

Comments

@tleguijt
Copy link
Collaborator

Related to the following PR: #57

MACH sets resource tags by default (at least; in Azure for now).
It should be possible to either extend or overwrite them in MACH with an extra tags setting in your Site configuration.

I think being able to overwrite them gives you the most flexibility. I think we should not provide both options (overwrite and extend) because it will make the configuration more complex.

@tleguijt tleguijt added azure Any Azure-related tickets discussion Tickets that are open for discussion enhancement New feature or request aws Any AWS-related tickets labels Dec 17, 2020
@MichielBijland
Copy link
Collaborator

maybe we can implement this in away that feels the same as AWS: #143

@mvantellingen
Copy link
Contributor

We should be able to define tags on global level and site level and component level. Tags set on site level should be passed to the plugins so that for example aws can set default tags

@demeyerthom demeyerthom removed azure Any Azure-related tickets aws Any AWS-related tickets labels Aug 17, 2023
@demeyerthom demeyerthom added this to the 2.10 milestone Aug 23, 2023
@demeyerthom demeyerthom removed their assignment Aug 23, 2023
@demeyerthom
Copy link
Contributor

I think this first requires #244, so we can change the plugin protocol and allow for setting and handling tags

@demeyerthom demeyerthom removed this from the 2.10 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Tickets that are open for discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants