Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename icrate features to end with _core #558

Closed
madsmtm opened this issue Jan 14, 2024 · 2 comments · Fixed by #592
Closed

Rename icrate features to end with _core #558

madsmtm opened this issue Jan 14, 2024 · 2 comments · Fixed by #592
Labels
A-framework Affects the framework crates and the translator for them enhancement New feature or request

Comments

@madsmtm
Copy link
Owner

madsmtm commented Jan 14, 2024

Rename Foundation to Foundation_core (and similarly for the other features).

@madsmtm madsmtm added enhancement New feature or request A-framework Affects the framework crates and the translator for them labels Jan 14, 2024
@mwcampbell
Copy link

Would this be a precursor to being able to build icrate with fewer bindings for large frameworks like AppKit? The AppKit feature currently enables several bindings that AccessKit, for example, doesn't need.

@madsmtm
Copy link
Owner Author

madsmtm commented Jan 24, 2024

No, the proper way to do that is to do cfgs based on file names instead.

I remember trying to make that work before, but it's quite difficult to do with Libclang, I'm hoping to get to it once we get further with #345.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Affects the framework crates and the translator for them enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants