Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peerflix does not correctly pass --meta-title #372

Open
lewisakura opened this issue Feb 28, 2021 · 1 comment
Open

Peerflix does not correctly pass --meta-title #372

lewisakura opened this issue Feb 28, 2021 · 1 comment

Comments

@lewisakura
Copy link

lewisakura commented Feb 28, 2021 •
edited
Loading

I noticed on the command line, Peerflix passes --meta-title wrapped in quotes, and does not properly escape all quotes, as well as inserting quotes that weren't even in the file in the first place (probably explains why it isn't escaping all quotes, I just realised they weren't even in the file name):
image
My quick skim of the code that deals with this shows no obvious issue, so I am not too sure why it's happening.
@lewisakura
Copy link
Author

I fixed this by passing { windowsVerbatimArguments: true } as a parameter to process.execFile. Seems to be some weird thing with Node that screws with arguments specifically on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lewisakura