-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customer Login Page is incorrectly cached with private data if Magento Captcha isn't enabled #39318
Comments
Hi @collymore. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Delta. Thank you for working on this issue.
|
Hi @collymore , Thanks for your reporting and collaboration. Can you please provide more steps that will help in replicating the issue. Thanks. |
Hi, I did a loom video. |
Preconditions and environment
Steps to reproduce
Expected result
The page returns FPC MISS.
The customer account form is using private data e.g The current Customer Email address is output in the forms login field" and this shouldn't be cached.
Actual result
The page response is returned with a Full page cache HIT.
If visiting the page after a cache clear and logged in, the email will be cached on the page for all subsequent requests.
Additional information
The only reason that the Customer Account Login page is not cached by default is the Magento_Captcha module's layout customer_account_login.xml file.
This is adding a bock name="captcha" to the container name="form.additional.info".
That block has cacheable="false" declared which then stops the login page from being cached.
Without this module activate nothing else is making the page non-cacheable.
Edit : This issue actually effects every Customer Account Form
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: