Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Update CartRepositoryInterface.php #39328

Open
m2-assistant bot opened this issue Nov 5, 2024 · 0 comments · May be fixed by #39316
Open

[Issue] Update CartRepositoryInterface.php #39328

m2-assistant bot opened this issue Nov 5, 2024 · 0 comments · May be fixed by #39316
Assignees
@apedicdev
Labels
Issue: ready for confirmation Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 5, 2024

This issue is automatically created based on existing pull request: #39316: Update CartRepositoryInterface.php

Given the save() implementation uses \Magento\Quote\Model\QuoteRepository\SaveHandler::save which throws 3 exceptions, I think they also should be declared at interface level
@m2-assistant m2-assistant bot linked a pull request Nov 5, 2024 that will close this issue
Open
1 task
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Nov 5, 2024
@engcom-Bravo engcom-Bravo added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Reported on 2.4.x Indicates original Magento version for the Issue report. and removed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apedicdev apedicdev

Labels
Issue: ready for confirmation Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Issue Confirmation and Triage Board
Status: Ready for Confirmation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CartRepositoryInterface.php apedicdev/magento2
2 participants
@apedicdev @engcom-Bravo