Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand indxer to support messages sent via smart contracts #581

Open
3 tasks
robdefeo opened this issue Mar 3, 2020 · 7 comments
Open
3 tasks

Expand indxer to support messages sent via smart contracts #581

robdefeo opened this issue Mar 3, 2020 · 7 comments
Labels
cmd/indexer enhancement New feature or request good first issue Good for newcomers

Comments

@robdefeo
Copy link
Member

robdefeo commented Mar 3, 2020

Is your feature request related to a problem? Please describe.
When sending a message via a smart contract the envelope is not at the beginning of the data field. Currently the check looks only at the prefix.

Describe the solution you'd like

  • replace check for prefix to look anywhere in the message payload
  • extend store transaction to include envelope data and transaction data as seperate fields
  • create tests

Additional context
Example transaction - https://ropsten.etherscan.io/tx/0x5371f7ab5c829036b7704139000a5fc2ad2ff7f2255c328c8e6ebecd227c73bc

@robdefeo robdefeo added enhancement New feature or request good first issue Good for newcomers cmd/indexer labels Mar 3, 2020
@rickynyairo
Copy link
Contributor

Hi @robdefeo, I'd like to work on this

@robdefeo
Copy link
Member Author

Thanks @rickynyairo I will assign this to you.

@tboeckmann
Copy link
Member

Hi @rickynyairo - how are you getting on with this issue? Are you still working on it?

@rickynyairo
Copy link
Contributor

Hi @tboeckmann
Sorry, please unassign me as I'm unable to complete it at the moment.

@stale
Copy link

stale bot commented Sep 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Mailchain team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please reply in order to keep the issue open. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Sep 5, 2020
@robdefeo robdefeo removed the Stale label Feb 7, 2021
@ygoryainov
Copy link

Hi @robdefeo and @tboeckmann,
can i try to work on it?

@marianososto
Copy link
Contributor

Hi @robdefeo I've been looking inside package ´cmd/indexer´ to understand where theses changes need to be applied but I'm not following the issue correctly. Can you give me some orientation/help on how to tackle this issue?
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/indexer enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants