Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to add token as .env variable instead of explicit declaration #36

Open
3 tasks
Agathe-Brusset opened this issue Feb 28, 2023 · 0 comments
Open
3 tasks
Assignees

Comments

@Agathe-Brusset
Copy link

To better enforce security on our SDKs and avoid incidents, please avoid suggesting our users set explicit declaration of the API/SMTP token in the code and instead suggest setting the API key as an environment variable.

  • Remove all mentions of the token added to any endpoint "ms.setToken("Your API token");"
  • Suggest users to add the token as a .env variable. Name the variable MAILERSEND_API_KEY.
  • Make it optional.

See Slack convo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants