Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency from config files within dss-test #438

Open
amusingaxl opened this issue Oct 31, 2024 · 1 comment
Open

Remove dependency from config files within dss-test #438

amusingaxl opened this issue Oct 31, 2024 · 1 comment

Comments

@amusingaxl
Copy link
Contributor

This PR shed light on a problem that currently exists in spells-mainnet.

To be able to set up the root domain for L2s, spell tests are required to read the input config from dss-test. However, this seems like an abuse of such config file, as it is intended to be used only for the integration tests of dss-test itself.

Ideally, we want to move those configs to spells-mainnet itself for better maintainability.

@TheMarvelFan
Copy link

Hi @amusingaxl ,

I would like to learn more and work on this issue, if no one already is.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants